Skip to content

port all patch and localized styles from style.css in vocabulary-theme #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 16, 2024
Merged

port all patch and localized styles from style.css in vocabulary-theme #49

merged 12 commits into from
Feb 16, 2024

Conversation

possumbilities
Copy link
Contributor

@possumbilities possumbilities commented Feb 13, 2024 •
edited
Loading

Description

  • port all non .home-narrative patches from vocabulary-theme to index-prototype, vocabulary.css
  • port all the .home-narrative patches from vocabulary-theme to index-prototype, style.css
  • correct default behavior of .attention banner, when no importance level applied.
  • port favicons dir from vocabulary-theme, implement in contexts head area
  • test that all imports are non-breaking

Note: A separate PR will have to be generated in vocabulary-theme to remove all these patches, and update to the newest version of vocabulary-lite from this repository.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@possumbilities possumbilities self-assigned this Feb 13, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 13, 2024 •
edited
Loading

✅ Deploy Preview for creativecommons-prototype ready!

Name Link
🔨 Latest commit 1a2c8c5
🔍 Latest deploy log https://app.netlify.com/sites/creativecommons-prototype/deploys/65cf80881ac7180009c49598
😎 Deploy Preview https://deploy-preview-49--creativecommons-prototype.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@possumbilities possumbilities marked this pull request as ready for review February 16, 2024 20:38
@possumbilities possumbilities requested review from a team as code owners February 16, 2024 20:38
@possumbilities possumbilities requested review from JackieBinya, fcoveram and nimishbongale and removed request for a team February 16, 2024 20:38
TimidRobot
TimidRobot approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@possumbilities possumbilities merged commit ebf1921 into main Feb 16, 2024
@possumbilities possumbilities deleted the patch-port branch February 16, 2024 22:00
@possumbilities possumbilities mentioned this pull request Feb 20, 2024
Closed
7 tasks
@possumbilities possumbilities linked an issue Feb 20, 2024 that may be closed by this pull request
Favicon and app icons not present on website #6
Closed
1 task
@possumbilities possumbilities mentioned this pull request Feb 20, 2024
Closed
1 task
@possumbilities possumbilities mentioned this pull request Mar 1, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimidRobot TimidRobot TimidRobot approved these changes

@Shafiya-Heena Shafiya-Heena Awaiting requested review from Shafiya-Heena

Assignees

@possumbilities possumbilities

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Favicon and app icons not present on website
2 participants
@possumbilities @TimidRobot